Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improved OP txpool batch validation #13972

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PoulavBhowmick03
Copy link

Closes #13902

Delegated validate_all function to a new function validate_batch from

/// Validates all given transactions.
fn validate_batch(

and then running the OP checks

@emhane emhane added C-perf A change motivated by improving speed, memory usage or disk footprint A-op-reth Related to Optimism and op-reth labels Jan 24, 2025
crates/optimism/node/src/txpool.rs Outdated Show resolved Hide resolved
@emhane
Copy link
Member

emhane commented Jan 24, 2025

duplicate of #13918

@PoulavBhowmick03
Copy link
Author

duplicate of #13918

Tbh I hadn't seen the contents of the PR since it was my first issue assigned and I tried to do it by myself. And thus it took me some time to come up with the solution

But if you still think this is a copy of that PR, then do let me know what I can do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve OP txpool batch validation
2 participants