refactor!: streamline OpBlockExecutionError error type to replace a hard-coded BlockExecutionError
#13696
+620
−326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chungquantin
requested review from
mattsse,
Rjected,
fgimenez,
rakita and
gakonst
as code owners
chungquantin
changed the title
OpBlockExecutionError
emhane
requested changes
Jan 13, 2025
chungquantin
requested review from
onbjerg,
shekhirin and
rkrasiuk
as code owners
This reverts commit 7bfd8a7.
emhane
requested changes
Jan 16, 2025
|
This should be rebased to resolve all the merge conflicts, it might become simpler as the legacy tree etc have been removed |
|
Sorry, will have to be rebased or merged again once #13839 is merged, since nightly clippy is broken right now |
That's ok, I don't see it as a breaking change. |
chungquantin
changed the title
OpBlockExecutionErrorOpBlockExecutionError error type to replace a hard-coded BlockExecutionError
chungquantin
changed the title
OpBlockExecutionError error type to replace a hard-coded BlockExecutionErrorOpBlockExecutionError error type to replace a hard-coded BlockExecutionError
emhane
reviewed
Jan 18, 2025
There was a problem hiding this comment.
when new trait BlockExecError (see comment about rename) is implemented for the OpBlockExecutionError too, then seems like this is possibly getting closed to finish :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current issue
Adding a variant and removing the conversion brings complexities everywhere
BlockExecutionErrorhard-coded in the associated type. TakesBlockExecutionStrategyFactory,BatchExecutororBlockExecutorProvider. And the conversion betweenOpBlockExecutionError -> BlockExecutionErroris still required in some parts of the code.Requires opinions from the core devs before taking extra steps to finish this PR.
Link to the issue: #13644
cc: @emhane