perf(trie): use local ThreadPool in Parallel::multiproof #13416
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aiming to prevent deadlocks when enabling
ParallelProof::multiproof
ref #13260 it allows us to process proofs in chunks, so that we don't spin up tasks for all the existing proofs at once, potentially causing resource exhaustion and rayon contention.the goal of this change is just to prevent the deadlock we were experimenting with when enabling parallel multiproof, but I also wanted to verify that splitting the workload in chunks doesn't add a significant overhead, fixing the time calculation for the state root task we have consistently better times compared to the regular calculation (state root task time is usually a bit above half of the parallel calculation time)