Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Pants Python interpreter from PATH. #70

Merged
merged 2 commits into from
Jan 24, 2023

Conversation

jsirois
Copy link
Contributor

@jsirois jsirois commented Jan 24, 2023

Since this interpreter is hobbled - it cannot build C extensions - it is
dangerous to have it discoverable on the PATH. Anyone needing to build C
extensions needs to supply their own local Python interpreter.

Fixes #69

Since this interpreter is hobbled - it cannot build C extensions - it is
dangerous to have it discoverable on the PATH. Anyone needing to build C
extensions needs to supply their own local Python interpreter.

Fixes pantsbuild#69
@jsirois
Copy link
Contributor Author

jsirois commented Jan 24, 2023

I'll follow up with a 0.2.2 release.

And the prep is now up in #72.

@jsirois
Copy link
Contributor Author

jsirois commented Jan 24, 2023

N.B.: Although this solves #69 it does not solve #71. #71 requires some hard decisions / restructure how 3rdparty plugins are packaged or consumed or both or it requires outlawing dependencies on distributions without wheels for the supported Pants platforms out on PyPI.

@sureshjoshi
Copy link
Member

sureshjoshi commented Jan 24, 2023

Is this something we'd want to mark in the getting started documentation, that if they need to build C extensions then (...)?

Wait, no, nevermind. This runs our stuff, not user stuff. That should be done using their selected Python interpreter

@jsirois jsirois merged commit 65d15ca into pantsbuild:main Jan 24, 2023
@jsirois jsirois deleted the issues/69 branch January 24, 2023 23:55
@jsirois
Copy link
Contributor Author

jsirois commented Jan 25, 2023

Yeah, exactly. No different than with ./pants since we never added that venv interpreter to the PATH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pants fails when trying to install plugins that depend on python C externsions
2 participants