Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yaml globs for Helm to support common chart structures #21692

Merged
merged 6 commits into from
Jan 31, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/notes/2.25.x.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ The `helm_infer.external_docker_images` glob syntax has been generalized. In ad

Fixed a bug where linting with the Helm backend enabled could induce serialization errors with the [workunit-logger](https://www.pantsbuild.org/2.25/reference/subsystems/workunit-logger).

The default "globs" for matching yaml in charts now matches more common structures.

#### Javascript

Fixed an issue where `pants run ...` commands only worked if the `package.json` file was in the root directory.
Expand Down
6 changes: 3 additions & 3 deletions src/python/pants/backend/helm/target_types.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,9 @@ class HelmChartSourcesField(MultipleSourcesField):
"values.yaml",
"values.yml",
"values.schema.json",
"templates/*.yaml",
"templates/*.yml",
"templates/*.tpl",
"templates/**/*.yaml",
"templates/**/*.yml",
"templates/**/*.tpl",
"templates/NOTES.txt",
"crds/*.yaml",
"crds/*.yml",
Expand Down
Loading