Problem: implementing custom comparison methods #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the comparison method to be created would benefit from being able to fall back onto the default implementation, it can't do so as these default methods are private to libfyaml and are not exposed. Solution: make them available as a public interface
yrashk
added a commit
to yrashk/omnigres
that referenced
this pull request
Jun 18, 2023
That is, it will put `t` or `f` into results. However, this is inconsistent with the rest of the YAML file where booleans are denoted standard YAML scalars for booleans. Solution: use `true` and `false` values for booleans This solution is not yet perfect because the comparison will not work correctly for different variations of the boolean scalars in YAML. Fixing this will require implementing custom comparator and this hinges on being able to (ideally) reuse the standard comparison algorithms with boolean comparison on top of it. I've previously sent a PR: pantoniou/libfyaml#85 but it wasn't merged yet.
|
@pantoniou have you had a chance to look at this, what do you think? |
|
Actually, I think there's an easier solution: just exposing I will send a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the comparison method to be created would benefit from being able to fall back onto the default implementation, it can't do so as these default methods are private to libfyaml and are not exposed.
Solution: make them available as a public interface