Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: retry readiness check S3 bucket creation with default config #146

Merged
merged 1 commit into from
Nov 21, 2024
Merged

refactor: retry readiness check S3 bucket creation with default config #146

merged 1 commit into from
Nov 21, 2024

Conversation

LucySuddenly
Copy link
Contributor

@LucySuddenly LucySuddenly commented Nov 21, 2024 •
edited
Loading

Background

  • We are getting inconsistent failures, we want to identify the cases to investigate, but also permit the readiness checker to continue without an error.

Changes

  • Retry failed test S3 bucket creation with default config
  • Log the failure without failing the check

Testing

  • How did you test your change?

@LucySuddenly LucySuddenly merged commit b4391dd into main Nov 21, 2024
1 check passed
@LucySuddenly LucySuddenly deleted the ls/retry-failed-LocationConstraint branch November 21, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacbrown zacbrown zacbrown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucySuddenly @zacbrown