Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test GHA runs unit tests #1476

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Test GHA runs unit tests #1476

merged 2 commits into from
Jan 22, 2025

Conversation

arielkr256
Copy link
Contributor

Background

The test GHA currently runs PAT test but not make test, which misses the unit tests for global helpers and data models.

Changes

  • Add make data-models-unit-test global-helpers-unit-test step to test workflow

Testing

  • GHA test

@arielkr256 arielkr256 requested a review from a team as a code owner January 15, 2025 16:23
@arielkr256 arielkr256 enabled auto-merge (squash) January 22, 2025 15:41
@arielkr256 arielkr256 merged commit 0bb44f3 into develop Jan 22, 2025
6 checks passed
@arielkr256 arielkr256 deleted the threat-439-make-test-gha branch January 22, 2025 15:42
@arielkr256 arielkr256 added the github_actions Pull requests that update GitHub Actions code label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-githubs ben-githubs ben-githubs approved these changes

@le4ker le4ker le4ker approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arielkr256 @le4ker @ben-githubs