-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Azure EntraID rules #1463
base: develop
Are you sure you want to change the base?
Conversation
Release 3.69.0
feat: new example rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great! Left a few comments and suggestions.
@@ -0,0 +1,5 @@ | |||
AnalysisType: global | |||
Filename: panther_azure_helpers.py | |||
GlobalID: "panther_azure_helpers" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put these in the existing panther_msft_helpers instead of creating a new helper module.
|
||
|
||
def rule(event): | ||
result = event.deep_get("properties", "result", default="") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use your new azure_success
helper!
"properties", "initiatedBy", "user", "userPrincipalName", default="" | ||
) | ||
target_name = get_target_name(event) | ||
role = deep_walk( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use event.deep_walk(...
|
||
def rule(event): | ||
operation = event.get("operationName", default="") | ||
if not azure_success or not operation.endswith(POLICY_OPERATION): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be azure_success(event)
?
|
||
def rule(event): | ||
operation = event.get("operationName", default="") | ||
if azure_success and "Add member to role in PIM completed" in operation: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
azure_success(event)
?
Background
Adding Azure EntraID rules
Changes
Testing
pat test
pat check-packs