Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVX-3831] Check for attempts at using old versions of PHP #2656

Merged
merged 1 commit into from
Dec 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/3x.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Terminus 3.x
name: Terminus 4.x
on:
push:
schedule:
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ A PHAR file must also be built before running tests.

The functional test files are in the `tests/Functional` directory.

The Terminus 3.x functional tests can be run via:
The Terminus 4.x functional tests can be run via:

```bash
cd /install/location/terminus
Expand Down
4 changes: 2 additions & 2 deletions bin/terminus
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
// Unset memory limit
ini_set('memory_limit', -1);

if (version_compare(PHP_VERSION, '7.4.0', '<') === true) {
if (version_compare(PHP_VERSION, '8.2.0', '<') === true) {
fwrite(STDERR, "\n");
fwrite(STDERR, 'Sorry, your PHP version (' . PHP_VERSION . ') is no longer supported.' . "\n");
fwrite(STDERR, 'Upgrade to PHP 7.4 or newer to use Terminus 3. For PHP versions prior to 7.4, downgrade to Terminus 2.x.' . "\n\n");
fwrite(STDERR, 'Upgrade to PHP 8.2 or newer to use Terminus 4. For PHP versions prior to 8.2, downgrade to Terminus 3.x.' . "\n\n");
fwrite(STDERR, 'For more information, see https://pantheon.io/docs/terminus/updates#php-version-compatibility-matrix' . "\n\n");
exit(1);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Commands/Self/Plugin/InstallCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public function migrate()
return;
}

// Get installed Terminus 3 plugins.
// Get installed Terminus 4 plugins.
$plugins = $this->getPluginProjects();
$t3projects = array_filter(
array_map(
Expand Down
Loading