-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal to add a Option field for REST API TTL #198
Conversation
For a general use case where a customer wants to set a specific cache TTL for WP REST API endpoints, we add a specific field for the REST API TTL value Alternatively, we can implement a custom plugin to set specific cache headers for these endpoints too, but that will be covered by another proposal or docs guide The intention here is to avoid modifying wp-config.php to achieve this, and specifically for those who want to disable cache for
09aa621
to
44cb8d1
Compare
3099389
to
6a2e86c
Compare
ba427d2
to
2fd3c5d
Compare
209ff39
to
17b1eec
Compare
20dd74a
to
a869620
Compare
b64c507
to
25f6f0b
Compare
25f6f0b
to
b96e33e
Compare
b75dc96
to
a03f6b7
Compare
d8a41fd
to
6df889e
Compare
c1b9c07
to
efc0d10
Compare
efa079e
to
5f322db
Compare
5624070
to
b246704
Compare
2ea00ca
to
08fe8bf
Compare
261df63
to
57d34e3
Compare
b5ed05d
to
ba8b498
Compare
@eabquina This looks solid to me. Do other plugins like the Fastly plugin cover this feature? Is there still a need for this? |
268402c
to
84e2e3f
Compare
9b1db5a
to
44d39ff
Compare
241cd26
to
abb3868
Compare
48f886d
to
ecbd459
Compare
33b4150
to
6fab2ff
Compare
8450036
to
b1760b3
Compare
c5e72a4
to
c8f3c84
Compare
801a5a6
to
a661407
Compare
c57e638
to
f5dc24c
Compare
3dd480d
to
9df76ec
Compare
f1e06b4
to
dac1c12
Compare
dac1c12
to
501a7b8
Compare
5d51b43
to
9715744
Compare
b86c4d4
to
8ba4079
Compare
bb3521e
to
b7f1c9e
Compare
426b254
to
c35f377
Compare
85121ff
to
b732454
Compare
6ff443d
to
42bad28
Compare
2828111
to
1f71462
Compare
It looks like the relevant changes here are in https://github.com/pantheon-systems/WordPress/pull/198/files#diff-33a6c2a1b5ee814d965675b811abf73fc82e318914f4aef019a47d1fc47aea08 and https://github.com/pantheon-systems/WordPress/pull/198/files#diff-295abdc06a001f46eff4c4e17e8cef60b77bbf6079cfca84b68cfcb2e876cc54 -- both of which have been moved to https://github.com/pantheon-systems/pantheon-mu-plugin. This PR should be closed with the relevant changes moved over to the mu-plugin repo. |
db3543f
to
9943ad6
Compare
fbd930e
to
cecd3a5
Compare
7a3aa1d
to
7178558
Compare
Closing in favor of pantheon-systems/pantheon-mu-plugin#24 |
For a general use case where a customer wants to set a specific cache TTL for WP REST API endpoints, we add a specific field for the REST API TTL value
Alternatively, we can implement a custom plugin to set specific cache headers for these endpoints too, but that will be covered by another proposal or docs guide
The intention here is to avoid modifying wp-config.php to achieve this, and specifically for those who want to disable cache for