add PR workflow #115
Merged
add PR workflow #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jhamman - this seems to work, so I say we merge as a temporary fix. There are some akward temporary fixes though (see #NOTE comments in build.py). Perhaps it's worth considering a bigger refactor (pinging @yuvipanda). Or as discussed on the call this week, only maintaining a single base-image that uses a conda metapackage for "pangeo-base" https://docs.conda.io/projects/conda-build/en/latest/resources/commands/conda-metapackage.html What I don't like in general is that this will clutter DockerHub with lots of "-PR" tagged images. But the Action workflow now uses a matrix configuration which is much cleaner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
creating PRs from forked repos will require users set up DOCKERHUB_PASSWORD and DOCKERHUB_USERNAME secrets in their fork. This is because GitHub Actions run in the forked branch for PRs and therefore don't have access to repo secrets.
This is testing a PR created from a branch with the new github actions build