Triage guide #29616
Triage guide #29616
Conversation
|
Awesome - great to have this info documented! @TomAugspurger |
|
|
||
| 5. **Is this a usage qusetion?** | ||
|
|
||
| We prefer that usage questions are asked on StackOverflow. If it's easy to |
There was a problem hiding this comment.
can you add the link to the https://stackoverflow.com/questions/tagged/pandas
|
@alimcmaster1 a couple questions, since you're our only triager so far:
|
|
|
||
| Occasionally, bugs are fixed but the issue isn't linked to in the Pull Request. | ||
| In these cases, comment that "This has been fixed, but could use a test." and | ||
| label the issue as "Good First Issue". |
There was a problem hiding this comment.
label the issue as "Good First Issue" and "Needs Test"
If helpful the full permissions matrix is here: Thanks! |
| of what it means to be a maintainer. | ||
|
|
||
| * Triage newly filed issues (see :ref:`maintaining.triage`) | ||
| * Review newly opened pull request |
There was a problem hiding this comment.
| * Review newly opened pull request | |
| * Review newly opened pull requests |
|
|
||
| Here's a typical workflow for triaging a newly opened issue. | ||
|
|
||
| 1. **Is the necessary information provided?** |
There was a problem hiding this comment.
I would maybe add a "1. Thank the reporter for opening an issue"
| Apply the relevant labels. This is a bit of an art, and comes with experience. | ||
| Look at similar issues to get a feel for how things are labeled. | ||
|
|
||
| If there issue is clearly defined and the fix seems relatively straightforward, |
There was a problem hiding this comment.
| If there issue is clearly defined and the fix seems relatively straightforward, | |
| If the issue is clearly defined and the fix seems relatively straightforward, |
|
|
||
| Ideally reporters would fill out the issue template, but many don't. | ||
| If crucial information (like the version of pandas they used), is missing | ||
| feel free to ask for that and label the issue with "Needs info". |
There was a problem hiding this comment.
Not sure if it fits here, or rather as an extra bullet point: has the issue a clear and descriptive title?
I think in the contributing guide there is somewhere a list of prefixes as well.
| ----------------------------- | ||
|
|
||
| Occasionally, contributors are unable to finish off a pull request. | ||
| If some time has passed (a week, say) since the last review requesting changes, |
There was a problem hiding this comment.
Nitpick: a week can pass fast (certainly if people do this in their free time), maybe recommend two weeks?
|
Thanks. Hopefully addressed everything in 5772227 |
|
thanks @TomAugspurger very nice! |
|
One thing I have noticed: The triage team gives me access to cancel/restart build jobs on Travis but not on Azure. I can add this info if we think its worth it. (But I know we are hoping to migrate off travis soon) Anyway just thought I would highlight |
Discussed on the dev call yesterday.
cc @pandas-dev/pandas-core. Any sections I'm missing? Any statements you disagree with?
xref pandas-dev/pandas-governance#11 (writing down a policy for triaging once we have one).