-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Update performance comparison section of io docs #28890
Merged
WillAyd
merged 26 commits into
pandas-dev:master
from
WuraolaOyewusi:Update-Performance-Comparison-section-of-IO-docs
Nov 9, 2019
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
4e85c6d
Merge pull request #1 from pandas-dev/master
WuraolaOyewusi 44df2ee
Merge pull request #2 from pandas-dev/master
WuraolaOyewusi b887983
Merge pull request #3 from pandas-dev/master
WuraolaOyewusi 9554ea6
Merge pull request #4 from pandas-dev/master
WuraolaOyewusi fd27a6f
Merge pull request #5 from pandas-dev/master
WuraolaOyewusi 3425a0a
Merge pull request #6 from pandas-dev/master
WuraolaOyewusi e53bce0
Update io.rst
WuraolaOyewusi 76ccef3
Update io.rst
WuraolaOyewusi 9672526
Update io.rst
WuraolaOyewusi d2c1e20
Update io.rst
WuraolaOyewusi 709d571
Update io.rst
WuraolaOyewusi ddd39f6
Update io.rst
WuraolaOyewusi 26b5db1
Update io.rst
WuraolaOyewusi cf85f95
Update io.rst
WuraolaOyewusi 3d71d40
Update io.rst
WuraolaOyewusi 8c8ed93
Update io.rst
WuraolaOyewusi 3e62c8f
Update io.rst
WuraolaOyewusi 1af539c
Update io.rst
WuraolaOyewusi ce51d5e
Update io.rst
WuraolaOyewusi 524c7e0
Update io.rst
WuraolaOyewusi 2b77c5d
Update io.rst
WuraolaOyewusi 2224738
restore indentation
jorisvandenbossche df377c1
fixup
jorisvandenbossche e3eba95
Update io.rst
WuraolaOyewusi 3aa5dea
Update io.rst
WuraolaOyewusi 0af75a0
Merge branch 'master' into Update-Performance-Comparison-section-of-I…
WuraolaOyewusi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed this here: it seems something went wrong with the compression (as it is exactly the same size as the non-compressed one; and also the timing is not slower). Maybe it did fall back to non-compressed because you didn't have the compression lib installed?
(however, if it does that silently, that feels like a bug to me)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorisvandenbossche I found out the original code had 3-space indentation, aligning my update to the previous code was the reason some checks failed. When I made the indentation 4-space. It passed.
Let me check the notebook again about the compression.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right about the compression.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorisvandenbossche, @datapythonista
I ran the codes again, tried version '0.25.0' and it's still the same. It seems like a bug.
What can I do to fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you open a separate issue, referencing this issue, explaining about the lack of compression in hdf.
@jorisvandenbossche probably worth merging this as is, and fix that in a separate PR, since it's an unrelated change. And looks like a bug in the code, and I guess the fix won't be trivial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok Marc