[Reference ]Feat/dynamic fee hook #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chefburger
force-pushed
the
feat/dynamic-fee-hook
branch
from
2dae20c to
8093073
Compare
chefburger
force-pushed
the
feat/dynamic-fee-hook
branch
from
8093073 to
27d7ff6
Compare
chefburger
force-pushed
the
feat/dynamic-fee-hook
branch
from
1c3f4a9 to
6a4664b
Compare
ChefJerry
reviewed
Oct 21, 2024
| returns (bytes4) | ||
| { | ||
| setDynamicLpFee(key, DEFAULT_LP_FEE); | ||
| return this.beforeInitialize.selector; |
There was a problem hiding this comment.
Suggested change
| return this.beforeInitialize.selector; | |
| return this.afterInitialize.selector; |
ChefJerry
reviewed
Oct 21, 2024
| bytes calldata hookData | ||
| ) external override returns (bytes4) { | ||
| setDynamicLpFee(key, DEFAULT_LP_FEE); | ||
| return this.beforeInitialize.selector; |
There was a problem hiding this comment.
Suggested change
| return this.beforeInitialize.selector; | |
| return this.afterInitialize.selector; |
There was a problem hiding this comment.
got it, do u want me to redeploy the contract ?
fix: return correct selector for beforeInit* hook
ChefJerry
approved these changes
Oct 22, 2024
|
Merge it since it has been heavily used for FE testing |
ChefJerry
reviewed
Nov 21, 2024
Comment on lines
+68
to
+73
| function beforeMint( | ||
| address, | ||
| PoolKey calldata, | ||
| IBinPoolManager.MintParams calldata, | ||
| bytes calldata | ||
| ) external override returns (bytes4, uint24) { |
There was a problem hiding this comment.
function beforeMint(
address,
PoolKey calldata,
+ IBinPoolManager.MintParams calldata
- IBinPoolManager.MintParams calldata,
- bytes calldata
) external override returns (bytes4, uint24) {There was a problem hiding this comment.
it has got updated #21. Thx for reminding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would only be used in FE tests, we might not want to merge it since the code isn't safe