fix: Ensure gauges not undefined or empty object and gauges fixes #10944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memoyil
requested review from
ChefMomota,
Chef-Yogi,
chefjackson,
ChefJerry,
thechefpenguin,
chef-eric and
chef-ryan
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
|
memoyil
commented
Nov 15, 2024
|
|
||
| return gauges | ||
| } | ||
| return [] as Gauge[] | ||
| throw Error('Failed to fetch gauges') |
There was a problem hiding this comment.
to retry if it fails
memoyil
force-pushed
the
feature/fix_ensure_gauges_not_undefined_or_empty_object
branch
from
b672a08 to
15ecaa7
Compare
memoyil
force-pushed
the
feature/fix_ensure_gauges_not_undefined_or_empty_object
branch
from
7f12618 to
99944fb
Compare
memoyil
changed the title
chef-ryan
previously approved these changes
Nov 16, 2024
memoyil
force-pushed
the
feature/fix_ensure_gauges_not_undefined_or_empty_object
branch
from
1651051 to
ed32bcd
Compare
|
@chef-ryan you can review it again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes search query removed when account connect
Fixes discrepancy between search query and list
Fixes undefined or empty gauges causes percent object constructor error
Memoize callbacks to reduce rerenders on client side
PR-Codex overview
This PR focuses on improving the functionality and robustness of the
GaugesVotingcomponents. Key changes include handling undefined values, enhancing performance withuseCallback, and refining the sorting and filtering mechanisms.Detailed summary
maxCapPercentto handle undefined values.useGaugesto ensure valid gauges.SearchInputwithuseCallbackfor better performance.FilterFieldInputto use a callback for change handling.GaugesTablesorting logic.useCallbackforhandleSortandhandleOnCollapsefunctions.