Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify example for ModuleLoader #1695

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Simplify example for ModuleLoader #1695

merged 1 commit into from
Dec 19, 2024

Conversation

charlax
Copy link
Contributor

@charlax charlax commented Jul 26, 2022

The ModuleLoader example seems copy pasted from ChoiceLoader. As a result it's not immediately clear how their API differ.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism davidism added the docs label Dec 18, 2024
@davidism davidism added this to the 3.1.5 milestone Dec 18, 2024
The `ModuleLoader` example seems copy pasted from `ChoiceLoader`. As a result it's not immediately clear how their API differ.
@davidism davidism changed the base branch from main to stable December 19, 2024 00:06
@davidism davidism merged commit 791dd3b into pallets:stable Dec 19, 2024
12 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants