Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vault tests): add ensure account #92

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix(vault tests): add ensure account #92

merged 1 commit into from
Dec 12, 2023

Conversation

teddyjfpender
Copy link
Contributor

Describe changes

Fixing tests that are failing.

Previously the @palladxyz/vault test for Accounts was failing with the following error:

TypeError: Cannot read properties of undefined (reading 'B62qjsV6WQwTeEWrNrRRBP6VaaLvQhwWTnFi4WP4LQjGvpfZEumXzxb')
 ❯ src/account/accountStore.ts:35:36
     33|       produce((state) => {
     34|         state.accounts[network][address] = {
     35|           ...state.accounts[network][address],
       |                                    ^
     36|           accountInfo
     37|         }

A quick fix using ensureAccount solves this. However further discussion is needed to define whether this is the best solution.

Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for pallad failed.

Name Link
🔨 Latest commit 298fd8c
🔍 Latest deploy log https://app.netlify.com/sites/pallad/deploys/6578e722af77f000080af4fb

@teddyjfpender teddyjfpender merged commit 4a2a370 into main Dec 12, 2023
1 of 4 checks passed
@teddyjfpender teddyjfpender deleted the fix/tests branch December 12, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant