Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Remove Truncation ✂️ #103

Merged
merged 5 commits into from
Dec 21, 2023
Merged

Chore: Remove Truncation ✂️ #103

merged 5 commits into from
Dec 21, 2023

Conversation

teddyjfpender
Copy link
Contributor

@teddyjfpender teddyjfpender commented Dec 21, 2023 •
edited
Loading

Describe changes

This PR addresses three points:

  • Issue Decimal Truncation in Transactions Tab #96 by removing truncation and making transaction & fee amounts three decimal places in the transaction tab.
  • Sending amounts other than integers.
  • Adding new Mina Icons

Screenshots

The transaction tab now looks like this:
Screenshot 2023-12-21 at 16 21 57

The overview tab now looks like this:
Screenshot 2023-12-21 at 16 22 27

@teddyjfpender teddyjfpender added bug Something isn't working beta testing Arised during beta testing labels Dec 21, 2023
@teddyjfpender teddyjfpender merged commit bc4a562 into main Dec 21, 2023
3 checks passed
@teddyjfpender teddyjfpender deleted the fix/transaction-amount-truncation branch December 21, 2023 21:23
@teddyjfpender teddyjfpender mentioned this pull request Dec 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrcnk mrcnk mrcnk approved these changes

Assignees
No one assigned
Labels
beta testing Arised during beta testing bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teddyjfpender @mrcnk