Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi arch support #806

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Multi arch support #806

wants to merge 16 commits into from

Conversation

pacostas
Copy link
Contributor

@pacostas pacostas commented Dec 6, 2024 •
edited
Loading

Merge instructions:

  • Merge after the jam has been updated with the latest packit go module.

Summary

This PR supports multi-arch for buildpacks. Is also backward compatible with the existing buildpacks workflow whether they support single or multi arch.

Current limitations:

  • It does not download if any dependecies on the buildpack.toml

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pacostas pacostas requested a review from a team as a code owner December 6, 2024 11:52
@pacostas pacostas marked this pull request as draft December 9, 2024 10:28
@mhdawson mhdawson added the semver:minor A change requiring a minor version bump label Dec 10, 2024
mhdawson
mhdawson previously approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

@pacostas is this meant to still be in draft ?

@pacostas
Copy link
Contributor Author

pacostas commented Dec 11, 2024 •
edited
Loading

@mhdawson Yes, I havent finished with the publish buildpack workflow yet and also packit is not updated on the jam CLI so it wont be able to produce the .cnb files properly. I have opened an issue about that paketo-buildpacks/jam#348 and also pinged them on slack, also further testing is needed for the backward compatibility, as we will have to merge it on github-config at some point.

@pacostas pacostas force-pushed the multi-arch branch 6 times, most recently from 1ff2289 to 483cc58 Compare December 16, 2024 16:01
@pacostas pacostas marked this pull request as ready for review December 16, 2024 16:01
@pacostas
Copy link
Contributor Author

pacostas commented Dec 16, 2024 •
edited
Loading

Merge after the jam has been updated with the latest packit go module.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 29, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson left review comments

@paketo-bot-reviewer paketo-bot-reviewer Awaiting requested review from paketo-bot-reviewer paketo-bot-reviewer is a code owner automatically assigned from paketo-buildpacks/nodejs-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pacostas @mhdawson