Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testdata must not use NodeJS 16 anymore #713

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Testdata must not use NodeJS 16 anymore #713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions integration/caching_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ func testCaching(t *testing.T, context spec.G, it spec.S) {
WithExtensions(
settings.Extensions.UbiNodejsExtension.Online,
).
WithEnv(map[string]string{"BP_NODE_VERSION": "~16"}).
WithEnv(map[string]string{"BP_NODE_VERSION": "~18"}).
WithBuildpacks(
settings.Buildpacks.NodeEngine.Online,
settings.Buildpacks.NPMInstall.Online,
Expand Down Expand Up @@ -255,7 +255,7 @@ func testCaching(t *testing.T, context spec.G, it spec.S) {
WithExtensions(
settings.Extensions.UbiNodejsExtension.Online,
).
WithEnv(map[string]string{"BP_NODE_VERSION": "~18"}).
WithEnv(map[string]string{"BP_NODE_VERSION": "~20"}).
WithBuildpacks(
settings.Buildpacks.NodeEngine.Online,
settings.Buildpacks.NPMInstall.Online,
Expand Down
2 changes: 1 addition & 1 deletion integration/testdata/dev_dependencies_during_build/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"url": ""
},
"engines": {
"node": "~16"
"node": "~18"
},
"devDependencies": {
"chalk": "^5.0.0"
Expand Down
2 changes: 1 addition & 1 deletion integration/testdata/empty_node_modules/package.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion integration/testdata/locked_app/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion integration/testdata/locked_app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
"url": ""
},
"engines": {
"node": "~16"
"node": "~18"
}
}
2 changes: 1 addition & 1 deletion integration/testdata/no_vendored_dependencies/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@
"express": "~4.0.0",
"chalk-cli": "~3.0.0"
},
"engines" : { "node" : "~>16" }
"engines" : { "node" : "~>18" }
}
2 changes: 1 addition & 1 deletion integration/testdata/npm-cache/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion integration/testdata/npm-cache/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@
"url": ""
},
"engines": {
"node": "~16"
"node": "~18"
}
}
2 changes: 1 addition & 1 deletion integration/testdata/npmrc/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
"url": ""
},
"engines": {
"node": "~16"
"node": "~18"
}
}
2 changes: 1 addition & 1 deletion integration/testdata/pre_post_scripts_vendored/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion integration/testdata/pre_post_scripts_vendored/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@
"url": ""
},
"engines": {
"node": "~16"
"node": "~18"
}
}
2 changes: 1 addition & 1 deletion integration/testdata/project_path_app/server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
"url": ""
},
"engines": {
"node": "~16"
"node": "~18"
}
}
2 changes: 1 addition & 1 deletion integration/testdata/simple_app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@
"url": ""
},
"engines": {
"node": "~16"
"node": "~18"
}
}
2 changes: 1 addition & 1 deletion integration/testdata/unmet_dep/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"logfmt": "^1.3.2"
},
"engines": {
"node": "~>16"
"node": "~>18"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion integration/testdata/vendored/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion integration/testdata/vendored/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@
"url": ""
},
"engines": {
"node": "~16"
"node": "~18"
}
}
2 changes: 1 addition & 1 deletion integration/testdata/with_nvmrc/.nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18
20
2 changes: 1 addition & 1 deletion integration/testdata/with_nvmrc/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion integration/testdata/with_nvmrc/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
"url": "http://github.com/cloudfoundry/nodejs-buildpack.git"
},
"engines": {
"node": "~16"
"node": "~18"
}
}
2 changes: 1 addition & 1 deletion integration/testdata/with_nvmrc_and_no_engine/.nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18
20
2 changes: 1 addition & 1 deletion integration/versioning_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ func testVersioning(t *testing.T, context spec.G, it spec.S) {
})

context("when using a nvmrc file", func() {
const nvmrcVersion = `18.\d+\.\d+`
const nvmrcVersion = `20.\d+\.\d+`

var (
image occam.Image
Expand Down
Loading