Skip to content

Commit

Permalink
Remove buildpack.toml, in favor of buildpack.toml.tmpl
Browse files Browse the repository at this point in the history
- Use go templating (./scripts/template.go) to construct the buildpack.toml when packaging/releasing cnbs
- The CHANGELOG is deprecated, in favor of release notes
- Use dagger.DeleteBuildpack to preserve built CNB in our release pipeline
[#166793497]:

Co-authored-by: David Freilich <[email protected]>
  • Loading branch information
ForestEckhardt and dfreilich committed Jul 9, 2019
1 parent 5f67b77 commit 620bcea
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 47 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@
*.tgz
npm-cnb_*
bin/
/buildpack.toml
43 changes: 0 additions & 43 deletions CHANGELOG

This file was deleted.

2 changes: 1 addition & 1 deletion buildpack.toml → buildpack.toml.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
[buildpack]
id = "org.cloudfoundry.npm"
name = "NPM Buildpack"
version = "0.0.9"
version = "{{ .Version }}"

[metadata]
include_files = ["bin/build","bin/detect","buildpack.toml"]
Expand Down
5 changes: 2 additions & 3 deletions integration/integration_test.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package integration_test

import (
"os"
"path/filepath"
"testing"

Expand Down Expand Up @@ -30,11 +29,11 @@ func TestIntegration(t *testing.T) {
Expect(err).NotTo(HaveOccurred())
npmURI, err = dagger.PackageBuildpack(bpDir)
Expect(err).ToNot(HaveOccurred())
defer os.RemoveAll(npmURI)
defer dagger.DeleteBuildpack(npmURI)

nodeURI, err = dagger.GetLatestBuildpack("node-engine-cnb")
Expect(err).ToNot(HaveOccurred())
defer os.RemoveAll(nodeURI)
defer dagger.DeleteBuildpack(nodeURI)

suite.Run(t)
}
Expand Down

0 comments on commit 620bcea

Please sign in to comment.