Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce BP_VERIFY_LAUNCHPOINT to enable generated files #615

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

c0d1ngm0nk3y
Copy link
Contributor

needed: paketo-buildpacks/libnodejs#37
fixes: #588

Summary

The env variable BP_VERIFY_LAUNCHPOINT can be used to not check that the file to launch exists.

Use Cases

If the file that should be launched is generated.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@c0d1ngm0nk3y c0d1ngm0nk3y requested a review from a team as a code owner November 29, 2024 12:42
@paketo-bot paketo-bot added the semver:patch A change requiring a patch version bump label Nov 29, 2024
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the supporting change from libnodejs has been pulled into the buildpack.

@c0d1ngm0nk3y
Copy link
Contributor Author

Lets wait for libnodejs being released and consumed. And then add this documentation.

@mhdawson mhdawson force-pushed the start-generated-apps branch from b3cb345 to f310706 Compare January 9, 2025 13:57
@mhdawson
Copy link
Member

PR to pull in updated libnodejs has landed. Going to land this PR.

@mhdawson mhdawson force-pushed the start-generated-apps branch from f310706 to 939877d Compare January 14, 2025 20:46
@mhdawson mhdawson enabled auto-merge (squash) January 14, 2025 20:46
@mhdawson mhdawson merged commit f5ec906 into main Jan 14, 2025
10 checks passed
@mhdawson mhdawson deleted the start-generated-apps branch January 14, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

too early in phases to detect if BP_LAUNCHPOINT is available
3 participants