Static stack support #495
Merged
Static stack support #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdimsdale
force-pushed
the
static-stack-support
branch
from
1189c0a to
b23263c
Compare
ForestEckhardt
approved these changes
Oct 10, 2023
- Add necessary flags/env for static linking.
- This was superseded by the introduction of testing against multiple builders, but was never removed.
robdimsdale
force-pushed
the
static-stack-support
branch
from
b23263c to
8aa6c48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the static stack out of the box. Specifically it sets:
CGO_ENABLED=0environment variable and-buildmode=defaultbuild flag when it detects it is running on the static stack.It does not set these if the user has already set a
-buildmodeflag (e.g. viaBP_GO_BUILD_FLAGS) on the assumption that if the user is setting this they want their value to be preserved even if the build fails.Additionally, this PR provides all the builders in the integration test, to ensure we are getting coverage on all supported stacks. It also cleans up some unused integration config.
Use Cases
See paketo-buildpacks/go#770
Checklist