Skip to content

feat: support custom trigger keys #240

feat: support custom trigger keys

feat: support custom trigger keys #240

Triggered via pull request March 10, 2024 03:19
@arihanvarihanv
synchronize #232
arihanv:main
Status Success
Total duration 1m 41s
Artifacts 1

test.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

3 errors, 2 warnings, and 1 notice
[webkit] › basic.test.ts:23:7 › basic behavior › item onSelect is called on click: test/basic.test.ts#L26
1) [webkit] › basic.test.ts:23:7 › basic behavior › item onSelect is called on click ───────────── Error: expect(received).toEqual(expected) // deep equality Expected: "Item selected" Received: "[HMR] connected" 24 | const item = page.locator(`[cmdk-item][data-value="Item"]`) 25 | const [message] = await Promise.all([page.waitForEvent('console'), item.click()]) > 26 | expect(message.text()).toEqual('Item selected') | ^ 27 | }) 28 | 29 | test('first item is selected by default', async ({ page }) => { at /home/runner/work/cmdk/cmdk/test/basic.test.ts:26:28
[webkit] › item.test.ts:63:7 › item advanced › re-rendering re-matches implicit textContent value: test/item.test.ts#L1
2) [webkit] › item.test.ts:63:7 › item advanced › re-rendering re-matches implicit textContent value Test timeout of 5000ms exceeded.
[webkit] › item.test.ts:63:7 › item advanced › re-rendering re-matches implicit textContent value: test/item.test.ts#L68
2) [webkit] › item.test.ts:63:7 › item advanced › re-rendering re-matches implicit textContent value Error: expect(locator).toHaveCount(expected) Locator: locator('[cmdk-item]') Expected: 0 Received: 2 Call log: - expect.toHaveCount with timeout 5000ms - waiting for locator('[cmdk-item]') - locator resolved to 2 elements - unexpected value "2" - locator resolved to 2 elements - unexpected value "2" - locator resolved to 2 elements - unexpected value "2" - locator resolved to 2 elements - unexpected value "2" - locator resolved to 2 elements - unexpected value "2" - locator resolved to 2 elements - unexpected value "2" - locator resolved to 2 elements - unexpected value "2" 66 | const button = page.locator(`data-testid=increment`) 67 | await button.click() > 68 | await expect(page.locator(`[cmdk-item]`)).toHaveCount(0) | ^ 69 | await button.click() 70 | await expect(page.locator(`[cmdk-item]`)).toHaveCount(2) 71 | }) at /home/runner/work/cmdk/cmdk/test/item.test.ts:68:47
test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, pnpm/action-setup@v2, actions/setup-node@v3, actions/upload-artifact@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
🎭 Playwright Run Summary
2 flaky [webkit] › basic.test.ts:23:7 › basic behavior › item onSelect is called on click ────────────── [webkit] › item.test.ts:63:7 › item advanced › re-rendering re-matches implicit textContent value 39 passed (31.8s)

Artifacts

Produced during runtime
Name Size
playwright-report Expired
54 KB