cocoapods, cran, vsm and cpan packages should not be lowered (#18)

* Dont lower cocoa, cpan, vsm and cran package names Cocoapods, CPAN, VSM and CRAN package managers are case sensitive and need the original name string - when the name is automatically lowered you cannot find the packages in the responsitory. * Update PackageUrl.cs * Update PackageUrl.cs Some managers also have case sensitive namespaces * Remove static from ValidateNamespace * Update PackageUrl.cs * Fix namespace switch * Add missing semicolon. * Per discussion. Remove all lowering and replace Removes the ToLower and the Replace methods which were modifying the ValidateName and ValidateNamespace methods. * Revert "Per discussion. Remove all lowering and replace" This reverts commit aa1a107. * Add Tests * Update src/PackageUrl.cs Co-authored-by: Adeel Mujahid <[email protected]> * Update PackageUrl.cs Co-authored-by: Adeel Mujahid <[email protected]>
package-url · Mar 3, 2022 · e93983a · e93983a
1 parent 1f7af04
commit e93983a
Show file tree

Hide file tree

Showing 2 changed files with 71 additions and 10 deletions.
diff --git a/src/PackageUrl.cs b/src/PackageUrl.cs
@@ -255,13 +255,17 @@ private static string ValidateType(string type)
             return type.ToLower();
         }
 
-        private static string ValidateNamespace(string @namespace)
+        private string ValidateNamespace(string @namespace)
         {
             if (@namespace == null)
             {
                 return null;
             }
-            return WebUtility.UrlDecode(@namespace.ToLower());
+            return Type switch
+            {
+                "vsm" or "cran" => WebUtility.UrlDecode(@namespace),
+                _ => WebUtility.UrlDecode(@namespace.ToLower())
+            };
         }
 
         private string ValidateName(string name)
@@ -270,15 +274,12 @@ private string ValidateName(string name)
             {
                 throw new MalformedPackageUrlException("The PackageURL name specified is invalid");
             }
-            if (Type == "pypi")
-            {
-                name = name.Replace('_', '-');
-            }
-            if (Type == "nuget")
+            return Type switch
             {
-                return name;
-            }
-            return name.ToLower();
+                "nuget" or "cocoapods" or "cpan" or "vsm" or "cran" => name,
+                "pypi" => name.Replace('_', '-').ToLower(),
+                _ => name.ToLower()
+            };
         }
 
         private static SortedDictionary<string, string> ValidateQualifiers(string qualifiers)

diff --git a/tests/TestAssets/test-suite-data.json b/tests/TestAssets/test-suite-data.json
@@ -277,5 +277,65 @@
     "qualifiers": null,
     "subpath": null,
     "is_invalid": false
+  },
+  {
+    "description": "cocoapods names are case sensitive",
+    "purl": "pkg:cocoapods/[email protected]",
+    "canonical_purl": "pkg:cocoapods/[email protected]",
+    "type": "cocoapods",
+    "namespace": null,
+    "name": "MapsIndoors",
+    "version": "3.24.0",
+    "qualifiers": null,
+    "subpath": null,
+    "is_invalid": false
+  },
+  {
+    "description": "cpan names are case sensitive",
+    "purl": "pkg:cpan/[email protected]",
+    "canonical_purl": "pkg:cpan/[email protected]",
+    "type": "cpan",
+    "namespace": null,
+    "name": "Perl-Version",
+    "version": "1.013",
+    "qualifiers": null,
+    "subpath": null,
+    "is_invalid": false
+  },
+  {
+    "description": "cran names are case sensitive",
+    "purl": "pkg:cran/[email protected]",
+    "canonical_purl": "pkg:cran/[email protected]",
+    "type": "cran",
+    "namespace": null,
+    "name": "MixTwice",
+    "version": "2.0",
+    "qualifiers": null,
+    "subpath": null,
+    "is_invalid": false
+  },
+  {
+    "description": "Visual Studio Marketplace namespaces are case sensitive",
+    "purl": "pkg:vsm/MS-CST-E/[email protected]",
+    "canonical_purl": "pkg:vsm/MS-CST-E/[email protected]",
+    "type": "vsm",
+    "namespace": "MS-CST-E",
+    "name": "vscode-devskim",
+    "version": "0.6.8",
+    "qualifiers": null,
+    "subpath": null,
+    "is_invalid": false
+  },
+  {
+    "description": "Visual Studio Marketplace names are case sensitive",
+    "purl": "pkg:vsm/ritwickdey/[email protected]",
+    "canonical_purl": "pkg:vsm/ritwickdey/[email protected]",
+    "type": "vsm",
+    "namespace": "ritwickdey",
+    "name": "LiveServer",
+    "version": "5.7.4",
+    "qualifiers": null,
+    "subpath": null,
+    "is_invalid": false
   }
 ]