Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deperecate use of process.env, add healthcheck #186

Merged
merged 10 commits into from
Dec 16, 2024
Merged

Deperecate use of process.env, add healthcheck #186

merged 10 commits into from
Dec 16, 2024

Conversation

Nospamas
Copy link
Contributor

  • Update references to use window.env
  • add default env.js file to public
  • Clean up various comments about config
  • update URLs to use beehive defaults for dev
  • update docker build to use static config
  • update github workflow to build to static directory and use that to build dockerfile

@Nospamas
Deperecate use of process.env, add healthcheck
4c70fe7 
- Update references to use window.env
- add default env.js file to public
- Clean up various comments about config
- update URLs to use beehive defaults for dev
- update docker build to use static config
- update github workflow to build to static directory and use that to build dockerfile
@Nospamas
Fix warnings via package updates, ignores. Update default url config …
5f09f88 
…to match local settings.
@Nospamas
update dockerfile to use slim image
303deec
@Nospamas
config adjustments, roll together env.js and config.yaml so they're l…
2619ac1 
…oaded together
@Nospamas
add serve.json to configure serve behaviour when in docker image
c9252e1
@Nospamas
try specifying location of serve.json
9f29f60
@Nospamas
config cleanup, use replaces
efcd603 
- Update dockerfile build
- Update .env values for expected replacements
- Update docs
@Nospamas
switch logger back to process.env variable
73b1947
@Nospamas Nospamas requested a review from rod-glover August 29, 2024 23:46
@Nospamas Nospamas changed the title WIP: Deperecate use of process.env, add healthcheck Deperecate use of process.env, add healthcheck Aug 29, 2024
@Nospamas
Copy link
Contributor Author

testable at https://beehive.pacificclimate.org/station-data-portal/pcds/portal

rod-glover
rod-glover requested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@rod-glover rod-glover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. A few small changes, some optional, and extra documentation. The more documentation of what you did and what you discovered in doing it, the better.

.env Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
craco.config.js Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
docker/bc.env.js Outdated Show resolved Hide resolved
docker/docker-compose.yaml Show resolved Hide resolved
docker/entrypoint.sh Show resolved Hide resolved
docker/ynwt.env.js Outdated Show resolved Hide resolved
public/env.js Outdated Show resolved Hide resolved
public/index.html Outdated Show resolved Hide resolved
@Nospamas
Update based on PR feedback
505c0ac 
- Better documentation
- Better naming conventions
@Nospamas Nospamas requested a review from rod-glover December 16, 2024 20:51
rod-glover
rod-glover approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@rod-glover rod-glover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, so much better to have static start-ups.

Only one comment: It would be good to have a description in the README's of what the workflow is and perhaps why it is like that.

@Nospamas Nospamas merged commit 8cd71c4 into master Dec 16, 2024
2 checks passed
@Nospamas Nospamas mentioned this pull request Dec 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rod-glover rod-glover rod-glover approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nospamas @rod-glover