Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project familiarisation adjustments. #175

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

Nospamas
Copy link
Contributor

  • Adjust styling a little, Remove unneeded card with border.
  • Adjust spacing so column buttons do not overlap content.
  • Add station data reload button to leaflet as learning exercise.

@Nospamas Nospamas requested a review from rod-glover January 16, 2024 21:45
Copy link
Contributor

@rod-glover rod-glover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Works as advertised.

@@ -77,7 +77,8 @@ export default class AdjustableColumns extends Component {
<Col lg={lg} hidden={lg === 0} key={i}>
<Row>
<Col lg={12} className={'text-center'} style={{
marginBottom: '-0.5em',
marginTop: '0.25em',
marginBottom: '0.25em',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original was intentional, to conserve space, but I agree it looks better (and more apparent) like this.

- Adjust styling a little, Remove unneeded card with border.
- Adjust spacing so column buttons do not overlap content.
- Add station data reload button to leaflet as learning exercise.
@Nospamas Nospamas force-pushed the station-data-refresh branch from eee600f to e895602 Compare January 17, 2024 00:21
@Nospamas Nospamas merged commit 1edb828 into master Jan 17, 2024
2 checks passed
@Nospamas Nospamas deleted the station-data-refresh branch January 17, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants