Merge pull request #471 from pacificclimate/deprecate-process-env

Deprecate use of process.env for runtime config

.devcontainer/devcontainer.json

@@ -16,7 +16,7 @@
     "ghcr.io/devcontainers/features/node:1": {
       "version": "22"
     },
-    "ghcr.io/devcontainers/features/docker-in-docker:1": {},
+    "ghcr.io/devcontainers/features/docker-in-docker:2.12.0": {},
     "ghcr.io/devcontainers/features/python:1": {
       "version": "3.8.10"
     }

.dockerignore

@@ -1,3 +1,4 @@
 .git
-build
-node_modules
+.idea
+
+**/*.env*

.env

@@ -1,7 +1 @@
-REACT_APP_TILECACHE_URL=https://services.pacificclimate.org/mapproxy/service
-REACT_APP_NCWMS_URL=https://beehive.pacificclimate.org/ncwms
-REACT_APP_CE_ENSEMBLE_NAME=ce_files
-REACT_APP_MAP_LAYER_ID_TYPE=dynamic
-REACT_APP_MAP_LAYER_ID_PREFIX=x
-REACT_APP_VARIABLE_OPTIONS=variable-options.yaml
-REACT_APP_EXTERNAL_TEXT=external-text/default.yaml
+PUBLIC_URL=%REPLACE_PUBLIC_URL%

.env.development

@@ -1,2 +1 @@
-REACT_APP_CE_BACKEND_URL=https://beehive.pacificclimate.org/pcex/api
-REACT_APP_CE_BASE_PATH=
+PUBLIC_URL=http://localhost:3001

.env.production

@@ -1,2 +1 @@
-REACT_APP_CE_BACKEND_URL=https://services.pacificclimate.org/pcex/api
-REACT_APP_CE_BASE_PATH=/pcex/app
+PUBLIC_URL=%REPLACE_PUBLIC_URL%

.github/workflows/docker-publish.yml

@@ -13,15 +13,20 @@ jobs:
 
     steps:
       - uses: actions/checkout@v2
-      - name: Export REACT_APP_CE_CURRENT_VERSION env var
+      - name: Export REACT_APP_APP_VERSION env var
         run: |
           git fetch --prune --unshallow
-          echo "REACT_APP_CE_CURRENT_VERSION=$(git describe --tags --abbrev=0) ($(git rev-parse --abbrev-ref HEAD):$(git log -1 --format=%h))" >> $GITHUB_ENV
+          echo "REACT_APP_APP_VERSION=$(git describe --tags --abbrev=0) ($(git rev-parse --abbrev-ref HEAD):$(git log -1 --format=%h))" >> $GITHUB_ENV
+      - name: Build npm package
+        run: |
+          npm ci
+          npm run build
       - name: Publish to Registry
         uses: docker/build-push-action@v1
         with:
           username: ${{ secrets.pcicdevops_at_dockerhub_username }}
           password: ${{ secrets.pcicdevops_at_dockerhub_password }}
+          dockerfile: docker/Dockerfile
           repository: pcic/climate-explorer-frontend
           tag_with_ref: true
-          build_args: REACT_APP_CE_CURRENT_VERSION=${{ env.REACT_APP_CE_CURRENT_VERSION }}
+          build_args: REACT_APP_APP_VERSION=${{ env.REACT_APP_APP_VERSION }}

Makefile

@@ -0,0 +1,16 @@
+# These variables are set to make it convenient to run the docker image locally.
+tag = $(shell git rev-parse --abbrev-ref HEAD)
+port = 30504
+public_url = http://localhost:${port}
+
+image:
+	@npm run build
+	@PCEX_TAG=$(tag) PCEX_PORT=$(port) docker compose -f docker/docker-compose.yaml build
+
+up:
+	@PCEX_TAG=$(tag) PCEX_PORT=$(port) docker compose -f docker/docker-compose.yaml up --force-recreate
+	@echo "Station Data Portal running on $(port)"
+	@docker logs -f station-data-portal-frontend
+
+down:
+	@PCEX_TAG=$(tag) PCEX_PORT=$(port) docker compose -f docker/docker-compose.yaml down