Skip to content

Commit

Permalink
fix: try to load SA name from values first (#9)
Browse files Browse the repository at this point in the history
`serviceAccount.name` should be used for both STS and the newly created
SA.

For example, when `serviceAccount.name` is different than
`chart.fullname` then STS will try to load non-existing SA.
  • Loading branch information
xom4ek authored Aug 21, 2024
2 parents 0ef6b08 + 83bd092 commit 34da168
Show file tree
Hide file tree
Showing 9 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion charts/aethos/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ appVersion: 0.1.0
description: A Helm chart for Kubernetes
name: aethos
type: application
version: 0.1.3
version: 0.1.4
maintainers:
- name: xom4ek
email: [email protected]
Expand Down
2 changes: 1 addition & 1 deletion charts/aethos/templates/pvc.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ metadata:
{{- toYaml . | nindent 4 }}
{{- end}}
spec:
storageClassName: oci-bv
storageClassName: {{ .Values.pvc.storageClassName }}
accessModes:
- ReadWriteOnce
resources:
Expand Down
2 changes: 1 addition & 1 deletion charts/aethos/templates/serviceaccount.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
apiVersion: v1
kind: ServiceAccount
metadata:
name: {{ include "aethos.fullname" . }}
name: {{ .Values.serviceAccount.name | default (include "aethos.fullname" .) }}
labels:
{{- include "aethos.labels" . | nindent 4 }}
{{- with .Values.labels }}
Expand Down
2 changes: 1 addition & 1 deletion charts/arpa/templates/serviceaccount.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
apiVersion: v1
kind: ServiceAccount
metadata:
name: {{ include "arpa.fullname" . }}
name: {{ .Values.serviceAccount.name | default (include "arpa.fullname" .) }}
labels:
{{- include "arpa.labels" . | nindent 4 }}
{{- with .Values.labels }}
Expand Down
2 changes: 1 addition & 1 deletion charts/k3/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ appVersion: 0.1.0
description: A Helm chart for Kubernetes
name: k3
type: application
version: 0.1.2
version: 0.1.3
maintainers:
- name: xom4ek
email: [email protected]
Expand Down
2 changes: 1 addition & 1 deletion charts/k3/templates/serviceaccount.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
apiVersion: v1
kind: ServiceAccount
metadata:
name: {{ include "k3.fullname" . }}
name: {{ .Values.serviceAccount.name | default (include "k3.fullname" .) }}
labels:
{{- include "k3.labels" . | nindent 4 }}
{{- with .Values.labels }}
Expand Down
2 changes: 1 addition & 1 deletion charts/lagrange/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ appVersion: 0.1.0
description: A Helm chart for Kubernetes
name: lagrange
type: application
version: 0.1.0
version: 0.1.1
maintainers:
- name: xom4ek
email: [email protected]
2 changes: 1 addition & 1 deletion charts/lagrange/templates/serviceaccount.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
apiVersion: v1
kind: ServiceAccount
metadata:
name: {{ include "lagrange.fullname" . }}
name: {{ .Values.serviceAccount.name | default (include "lagrange.fullname" .) }}
labels:
{{- include "lagrange.labels" . | nindent 4 }}
{{- with .Values.labels }}
Expand Down
2 changes: 1 addition & 1 deletion charts/openoracle/templates/serviceaccount.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
apiVersion: v1
kind: ServiceAccount
metadata:
name: {{ include "openoracle.fullname" . }}
name: {{ .Values.serviceAccount.name | default (include "openoracle.fullname" .) }}
labels:
{{- include "openoracle.labels" . | nindent 4 }}
{{- with .Values.labels }}
Expand Down

0 comments on commit 34da168

Please sign in to comment.