fix UI deadlocks + improve visual word colors #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajnavarro
reviewed
May 13, 2022
Comment on lines
+114
to
+118
| go func() { | ||
| // mark as initialized after ~200 milliseconds | ||
| time.Sleep(200 * time.Millisecond) | ||
| *initialized = true | ||
| }() |
There was a problem hiding this comment.
hmm, basing initialization on a timer is not a good idea in my opinion. You should have someplace in your code where you are sure everything is initialized.
Comment on lines
+37
to
+40
| // wait untill UI is initialilzed | ||
| for !ui.uiInitialized { | ||
| time.Sleep(200 * time.Millisecond) | ||
| } |
There was a problem hiding this comment.
Instead of doing this, you can call SetLog when you know you can do it (UI is initialized) from the parent class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed problem with the
terminal manager(tview) that was freezing the entire UI.Added a flag that restricts printing debug messages in the console until the UI is initialized.
NOTE: We can play alone even if we don't have any peers connected, we should take a look at it (the user can achieve a longer word count by playing in localhost and then connecting to the network)