Fix Patient weight and DOB sync #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruhanga
reviewed
Dec 9, 2024
Comment on lines
+125
to
+127
| if (saleOrder.getPartnerWeight() == null | ||
| || saleOrder.getPartnerWeight().isEmpty() | ||
| || saleOrder.getPartnerWeight().equals("false")) { |
There was a problem hiding this comment.
Is this not supposed to get the actual numeric weight of the partner instead of a boolean?
There was a problem hiding this comment.
So in Odoo if the field is null it is set as False that's why we cast it to String in our eip routes.
rbuisson
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for: