Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3.4 as a supported version #474

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

stanhu
Copy link
Contributor

@stanhu stanhu commented Dec 28, 2024

Also test Ruby 3.4.x in CI.

@stanhu stanhu closed this Dec 28, 2024
@stanhu stanhu force-pushed the sh-add-ruby-3.4-version branch from f6c02dd to 4a981cb Compare December 28, 2024 08:34
@stanhu stanhu reopened this Dec 28, 2024
@stanhu stanhu force-pushed the sh-add-ruby-3.4-version branch 2 times, most recently from f839a10 to d983667 Compare December 28, 2024 08:50
@@ -34,7 +34,7 @@ jobs:
fail-fast: false
matrix:
# Test against all versions supported by rubygems
ruby_version: ["2.7", "3.0", "3.1", "3.2", "3.3", "3.4.0-preview2"]
ruby_version: ["2.7", "3.0", "3.1", "3.2", "3.3", "3.4"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems https://github.com/oxidize-rb/rb-sys/pull/472/files already handles this, so I'll pull this commit.

@stanhu stanhu force-pushed the sh-add-ruby-3.4-version branch from d983667 to 09a8810 Compare December 28, 2024 16:15
@ianks
Copy link
Collaborator

ianks commented Dec 28, 2024

thank you!

@ianks ianks merged commit ab44516 into oxidize-rb:main Dec 28, 2024
55 of 56 checks passed
@stanhu
Copy link
Contributor Author

stanhu commented Dec 28, 2024

@ianks Thanks for the quick merge! I'm having trouble using ruby_gte_3_4 in my Ruby 3.4.1 app even after updating to v0.9.105. RB_SYS_ENV_DEBUG=1 cargo build shows that the 3_4 defintions are there:

  cargo:rustc-check-cfg=cfg(ruby_version_lt_3_4)
  cargo:rustc-check-cfg=cfg(ruby_version_gt_3_4)
  cargo:rustc-check-cfg=cfg(ruby_version_gte_3_4)
  cargo:rustc-check-cfg=cfg(ruby_version_eq_3_4)
  cargo:rustc-check-cfg=cfg(ruby_version_lte_3_4)
  cargo:rustc-check-cfg=cfg(ruby_3_4)
  cargo:rustc-cfg=ruby_3_4
  cargo:rustc-check-cfg=cfg(ruby_3_4_1)
  cargo:rustc-cfg=ruby_3_4_1

Does rb-sys-env also need to be updated?

UPDATE: The compile works if I point to main:

[build-dependencies]
rb-sys-env = { git = "https://github.com/oxidize-rb/rb-sys.git", branch = "main" }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants