[full-ci] @vue/compat #8128
Merged
[full-ci] @vue/compat #8128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
JammingBen
force-pushed
the
vue3-compat-ng
branch
from
be281ee to
5aab243
Compare
|
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/31217/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31217/tracing/copy-and-move-resources-in-personal-space-alice-2023-1-5-12-08-10.zip |
|
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/31217/12/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31217/tracing/copy-and-move-resources-in-personal-space-alice-2023-1-5-12-07-34.zip |
dschmidt
force-pushed
the
vue3-compat-ng
branch
from
20c41d8 to
9f6d41e
Compare
JammingBen
force-pushed
the
vue3-compat-ng
branch
from
ca1dc13 to
9945ff8
Compare
dschmidt
force-pushed
the
vue3-compat-ng
branch
from
da07617 to
2f5001f
Compare
dschmidt
commented
Dec 21, 2022
dschmidt
commented
Dec 21, 2022
...es/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue
Outdated
Show resolved
Hide resolved
dschmidt
commented
Dec 21, 2022
packages/web-app-files/tests/mocks/useResourcesViewDefaultsMock.ts
Outdated
Show resolved
Hide resolved
dschmidt
force-pushed
the
vue3-compat-ng
branch
from
4e9d19c to
6e9cebf
Compare
dschmidt
changed the base branch from
master
to
merge-stable-6.0-to-master-20221222-0
dschmidt
changed the base branch from
merge-stable-6.0-to-master-20221222-0
to
master
dschmidt
force-pushed
the
vue3-compat-ng
branch
from
94e07e4 to
bd086ff
Compare
This was referenced Dec 22, 2022
Closed
5 tasks
dschmidt
commented
Dec 23, 2022
There was a problem hiding this comment.
We should check if we have more usages of $listeners or $attrs and if they still work everywhere.
Moreover we should check for .native modifiers for events and get rid of all of them.
In general I'd say this is in pretty good shape and needs only minor fixes now
packages/design-system/src/components/OcDatepicker/OcDatepicker.vue
Outdated
Show resolved
Hide resolved
| import iconColorMap from '../../helpers/resourceIconColorExtensionMapping.json' | ||
| import iconNameMap from '../../helpers/resourceIconExtensionMapping.json' | ||
| import * as iconColorMap from '../../helpers/resourceIconColorExtensionMapping.json' | ||
| import * as iconNameMap from '../../helpers/resourceIconExtensionMapping.json' |
There was a problem hiding this comment.
This is ugly but we couldn't fix it otherwise in Vite AND jest. It's used at runtime in the documentation, so we couldnt simply convert it to ts 🌚
Hopefully we can soon switch to vitest and have it flxed there...
packages/design-system/src/components/OcTextarea/OcTextarea.vue
Outdated
Show resolved
Hide resolved
packages/design-system/src/components/_OcTableCell/OcTableCell.spec.ts
Outdated
Show resolved
Hide resolved
packages/design-system/src/components/_OcTableCell/_OcTableCell.vue
Outdated
Show resolved
Hide resolved
packages/web-pkg/src/composables/clientService/useClientService.ts
Outdated
Show resolved
Hide resolved
packages/web-pkg/src/composables/translations/useTranslations.ts
Outdated
Show resolved
Hide resolved
saw-jan
reviewed
Dec 29, 2022
tests/acceptance/features/webUISharingPublicExpire/shareByPublicLinkExpiringLinks.feature
Outdated
Show resolved
Hide resolved
JammingBen
force-pushed
the
vue3-compat-ng
branch
2 times, most recently
from
3cef14a to
8bef656
Compare
JammingBen
force-pushed
the
vue3-compat-ng
branch
from
8bef656 to
11e8dc8
Compare
JammingBen
force-pushed
the
vue3-compat-ng
branch
3 times, most recently
from
55f2918 to
48702c2
Compare
kulmann
reviewed
Jan 9, 2023
dschmidt
force-pushed
the
vue3-compat-ng
branch
from
0f248c2 to
cb2c929
Compare
kulmann
reviewed
Jan 9, 2023
packages/web-app-admin-settings/tests/unit/components/AppTemplate.spec.ts
Show resolved
Hide resolved
| @@ -198,7 +198,8 @@ export default defineComponent({ | |||
| }, | |||
| setup(props) { | |||
| const instance = getCurrentInstance().proxy | |||
| const uppyService = instance.$uppyService | |||
| const uppyService = | |||
| getCurrentInstance().proxy.$uppyService || getCurrentInstance().parent.proxy.$uppyService | |||
There was a problem hiding this comment.
Looks to me like you implemented that in this PR. Could you make use of it here?
packages/web-pkg/src/composables/clientService/useClientService.ts
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
|
Omg this has been merged? 😱😱 awesomeeee! |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade Vue to use the Vue 3 compat mode.
Related Issue