Add data download handling for multi-dims #4495
Merged
+85
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
rakyi
commented
Jan 28, 2025
| @@ -265,10 +269,10 @@ export function constructReadme( | |||
|
|
|||
| const downloadDate = formatDate(new Date()) // formats the date as "October 10, 2024" | |||
| if (isSingleColumn) | |||
| readme = `# ${grapher.title} - Data package | |||
| readme = `# ${grapher.displayTitle} - Data package | |||
There was a problem hiding this comment.
grapher.title is undefined for mdims. The title we show in the UI gets set after we fetch the indicator metadata, so we have to use grapher.displayTitle. This should be safe also for normal graphers, since we return grapher.title from grapher.displayTitle, if it exists.
rakyi
commented
Jan 28, 2025
| @@ -295,6 +299,9 @@ export const MultiDimDataPageContent = ({ | |||
| const grapherConfigComputed = useMemo(() => { | |||
| const baseConfig: GrapherProgrammaticInterface = { | |||
| bounds, | |||
| bakedGrapherURL: BAKED_GRAPHER_URL, | |||
There was a problem hiding this comment.
We need this for constructing the URLs we show in the downloads modal.
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2025-01-28 11:06:53 UTC |
rakyi
force-pushed
the
mdim-data-download
branch
from
080c5e9 to
41f7052
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4457