Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ check there's no slug collision before publishing #4494

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

ikesau
Copy link
Member

@ikesau ikesau commented Jan 27, 2025

Resolves #4493

Compares via canonical URL in the event we want /data-insights/some-slug and /some-slug

Renamed addImagesToContentGraph to setImagesToContentGraph because I was confused when reading it to see that it also took care of deleting images from the content graph if unpublishing.

collisions.mp4

@ikesau ikesau requested a review from rakyi January 27, 2025 20:42
@ikesau ikesau self-assigned this Jan 27, 2025
@owidbot
Copy link
Contributor

owidbot commented Jan 27, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-slug-collisions

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2025-01-27 20:59:51 UTC
Execution time: 1.26 seconds

Copy link
Contributor

@rakyi rakyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice QoL improvement!

@ikesau ikesau merged commit 467ac6f into master Jan 28, 2025
25 checks passed
@ikesau ikesau deleted the slug-collisions branch January 28, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate that slug is unique before publishing/republishing a gdoc
3 participants