-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add narrative-chart and figma-url to DI frontmatter / TAS-850 #4489
base: master
Are you sure you want to change the base?
Conversation
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2025-01-27 09:51:46 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a perfectly implemented PR, but I worry we're starting to overload these warnings so that authors will learn to ignore them 🙈
I think the checklist method works better for them, so hopefully your DI tool will make this a non-issue anyway because they'll have already filled everything, everytime, before hitting publish. 🙂
Oh, you might want to add these to the e.g. inspect We probably don't want arbitrary figma URLs getting embedded in our HTML 🙂 |
That's a good point! I'm almost inclined to remove all warnings – or maybe keep the warning for the |
3588f43
to
38a0ed4
Compare
9004e2f
to
aed91a1
Compare
aed91a1
to
54b0129
Compare
Adds two new properties to the front matter of DIs.
narrative-chart
is the name of a narrative chart. It's useful to know which narrative chart a DI is based on, similar to how we track thegrapher-url
a DI is based on.figma-url
is a link to a Figma page. Authors are encouraged to share a Figma link if they customised the chart, but currently paste the link into the comment section of the GDoc. We double-down on Figma as an important piece of infrastructure this cycle, so I think it's justified to track it properly.Both properties will be surfaced in a new Data Insights index page we have in mind.
This is part 1 of 3 in a stack made with GitButler: