Update base TSConfig to options supported by Node 22 #4481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelgerber
approved these changes
Jan 23, 2025
|
|
||
| "lib": ["dom", "dom.iterable", "es2020", "es2021", "es2022", "es2023"], | ||
| "target": "es2019", | ||
| "lib": ["dom", "dom.iterable", "es2023"], |
There was a problem hiding this comment.
Suggested change
| "lib": ["dom", "dom.iterable", "es2023"], | |
| "lib": ["dom", "dom.iterable", "es2023", "ESNext.Collection"], |
should hopefully work :) (well, I haven't really extensively tried it, but I don't know why it wouldn't work)
There was a problem hiding this comment.
Ahh, this might work for the new set intersection and friends. I'll try it in #4478
https://www.npmjs.com/package/@tsconfig/node22 We still have to override `module` and `moduleResolution` because `node16` causes issues with imports of external packages like `instantsearch.js`.
rakyi
force-pushed
the
tsconfig-node-22
branch
from
37e5fc4 to
a85fa6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.npmjs.com/package/@tsconfig/node22
We still have to override
moduleandmoduleResolutionbecausenode16causes issues with imports of external packages likeinstantsearch.js.