Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ download unfiltered data on client #4447

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Jan 14, 2025

The server currently uses grapher.inputTable to prep data for download, but client side uses grapher.table. Daniel prefers grapher.inputTable, so I'm switching the client to use that as well.


This is part 2 of 2 in a stack made with GitButler:

@sophiamersmann sophiamersmann force-pushed the fix-filtered-data-download branch from fcab837 to 7d02902 Compare January 14, 2025 11:44
@sophiamersmann sophiamersmann force-pushed the download-all-data-on-client branch from 3b22cb2 to 32ee11f Compare January 14, 2025 11:44
@owidbot
Copy link
Contributor

owidbot commented Jan 14, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-download-all-data-on-client

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 220 (530ce3) ❌

Edited: 2025-01-14 12:03:41 UTC
Execution time: 1.23 seconds

Base automatically changed from fix-filtered-data-download to master January 14, 2025 12:17
@sophiamersmann sophiamersmann merged commit 7e95bbe into master Jan 14, 2025
18 checks passed
@sophiamersmann sophiamersmann deleted the download-all-data-on-client branch January 14, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging-viz Let SVG tester fail silently in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants