-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Site Nav from tag graph #4439
base: master
Are you sure you want to change the base?
Conversation
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2025-01-13 22:01:06 UTC |
e9a303e
to
9af48d6
Compare
isOnHomepage = props?.content?.type === OwidGdocType.Homepage | ||
} | ||
ReactDOM.render( | ||
<SiteNavigation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically we don't need to fetch the topicTagGraph.json
when we're on the homepage, because it's already embedded in the homepage gdoc's homepageMetadata
, but seeing as the JSON request is ~4kB transferred, I think it's okay to not optimize.
Later, we should see if it's possible to get this file and dods.json
to cache.
Removes the hardcoded
SiteNavigationStatic
object that powered the site nav and replaces it with a JSON file representation of the tag graph from the database.As a reminder, the tag graph shape is: