Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 compare colors using lower case hex codes #4438

Merged
merged 1 commit into from
Jan 10, 2025
Merged

🐛 compare colors using lower case hex codes #4438

merged 1 commit into from
Jan 10, 2025

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Jan 10, 2025 •
edited
Loading

Resolves #4141

@github-actions github-actions bot added the staging-viz Let SVG tester fail silently in CI label Jan 10, 2025
@owidbot
Copy link
Contributor

owidbot commented Jan 10, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-lower-case-colors

SVG tester:

Number of differences (default views): 2119 (1a3639) ❌
Number of differences (all views): 2144 (db35da) ❌

Edited: 2025-01-10 16:36:03 UTC
Execution time: 1.21 seconds

@sophiamersmann sophiamersmann marked this pull request as ready for review January 10, 2025 16:39
@sophiamersmann sophiamersmann merged commit 77be4db into master Jan 10, 2025
27 checks passed
@sophiamersmann sophiamersmann deleted the lower-case-colors branch January 10, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sophiamersmann sophiamersmann

Labels
staging-viz Let SVG tester fail silently in CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LineChart: Entities are assigned the same colour (although unused colours are available)
2 participants
@sophiamersmann @owidbot