Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ disallow log y-scale for discrete bar charts / TAS-802 #4436

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Jan 10, 2025

Resolves #4364

Shows a discrete and stacked discrete bar chart with a linear scale always.

In particular:

  • Hides the 'Enable log/linear toggle' in the admin for discrete bar charts
  • Hides log/linear toggle in the settings menu for discrete bar charts
  • Forces discrete bar charts to use a linear scale, even if the axis config says otherwise

@github-actions github-actions bot added the staging-viz Let SVG tester fail silently in CI label Jan 10, 2025
@sophiamersmann sophiamersmann changed the title ✨ disallow log y-scale for discrete bar charts ✨ disallow log y-scale for discrete bar charts / TAS-802 Jan 10, 2025
Copy link

@owidbot
Copy link
Contributor

owidbot commented Jan 10, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-disallow-log-scale-for-bar-c

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 240 (75e92c) ❌

Edited: 2025-01-10 15:54:15 UTC
Execution time: 1.28 seconds

@sophiamersmann sophiamersmann marked this pull request as ready for review January 10, 2025 16:36
Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks!

@sophiamersmann sophiamersmann merged commit bb5d2e4 into master Jan 14, 2025
31 checks passed
@sophiamersmann sophiamersmann deleted the disallow-log-scale-for-bar-charts branch January 14, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging-viz Let SVG tester fail silently in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disallow log scale for discrete bar charts
3 participants