Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐝 automatically add 'staging-viz' label to my PRs #4428

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Jan 9, 2025

I know it's unconventional to have an action target my PRs only, but manually adding the 'staging-viz' label to all of my PRs is soo annoying.

The 'staging-viz' label makes it so that the SVG tester doesn't fail when there are differences. That's the better default for me since SVG changes are expected for most of my PRs.


This is part 1 of 2 in a stack made with GitButler:

@sophiamersmann sophiamersmann force-pushed the automatic-staging-viz branch 6 times, most recently from 947c442 to 8504d2a Compare January 9, 2025 16:39
@sophiamersmann sophiamersmann mentioned this pull request Jan 9, 2025
@sophiamersmann sophiamersmann marked this pull request as ready for review January 9, 2025 16:47
@owidbot
Copy link
Contributor

owidbot commented Jan 9, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-automatic-staging-viz

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2025-01-09 17:17:04 UTC
Execution time: 1.25 seconds

Copy link
Contributor

@larsyencken larsyencken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good with me. Since it's scoped to you and won't affect anyone else, feel free to add personalised automation here.

@sophiamersmann sophiamersmann merged commit 98092b8 into master Jan 10, 2025
26 checks passed
@sophiamersmann sophiamersmann deleted the automatic-staging-viz branch January 10, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants