Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatting for numbers in data catalog #4424

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

rakyi
Copy link
Contributor

@rakyi rakyi commented Jan 9, 2025

Number formatting was requested by Marwa and as I was changing it I noticed we set a wrong canonical URL for the data catalog, so I fixed that too.

@rakyi rakyi requested a review from ikesau January 9, 2025 14:48
Copy link
Member

@ikesau ikesau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!!

@ikesau ikesau changed the title Comafy data catalog Commafy data catalog Jan 9, 2025
@rakyi rakyi changed the title Commafy data catalog Add formatting for numbers in data catalog Jan 9, 2025
@rakyi rakyi merged commit 04d8c52 into master Jan 9, 2025
24 of 26 checks passed
@rakyi rakyi deleted the comafy-data-catalog branch January 9, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants