Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix citation metadata #4401

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Fix citation metadata #4401

merged 2 commits into from
Jan 9, 2025

Conversation

rakyi
Copy link
Contributor

@rakyi rakyi commented Jan 8, 2025

Fixes #3575

@rakyi rakyi requested a review from mlbrgl January 8, 2025 10:05
@rakyi rakyi force-pushed the fix-citation-data branch from fb06105 to 9082f2c Compare January 8, 2025 10:18
@owidbot
Copy link
Contributor

owidbot commented Jan 8, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-fix-citation-data

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2025-01-08 10:33:33 UTC
Execution time: 1.21 seconds

@@ -84,7 +84,7 @@ export default function OwidGdocPage({
debug?: boolean
isPreviewing?: boolean
}) {
const { content, createdAt, updatedAt } = gdoc
const { content, createdAt, publishedAt } = gdoc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

Copy link
Member

@mlbrgl mlbrgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad we removed that discrepancy, thanks for tackling it!

@rakyi rakyi force-pushed the fix-citation-data branch from 9082f2c to c700dcf Compare January 9, 2025 10:31
rakyi added 2 commits January 9, 2025 11:37
It should be the same as we display to the reader in the post, which is
the publication date.
@rakyi rakyi force-pushed the fix-citation-data branch from c700dcf to ff48d5a Compare January 9, 2025 10:37
@rakyi rakyi merged commit 34fb547 into master Jan 9, 2025
22 checks passed
@rakyi rakyi deleted the fix-citation-data branch January 9, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align meta citation information with publication date and authors in article header and citations
3 participants