new table for chart (and possibly other objects) revisions #4387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2025-01-06 15:32:24 UTC |
…-grapher into db-table-housekeeping
Marigold
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Looks good. If you plan to use it in ETL, it's a good idea to add it to grapher/model.py, too.
If you want to test the whole thing on staging, you can create a branch with the same name db-table-housekeeping in ETL. That staging server should then use PRs from both repos.
sophiamersmann
pushed a commit
that referenced
this pull request
Jan 8, 2025
* init * init * 🤖 style: prettify code
danyx23
pushed a commit
that referenced
this pull request
Jan 9, 2025
* init * init * 🤖 style: prettify code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
In owid/etl#3792 I'm working on a bot that will suggest a chart for revision daily. It'll be a public chart, that has few visits.
We want to avoid suggesting the same chart multiple times, so we need to track what has already been suggested. This PR adds a new table for that.
I had thought of a table named
suggested_reviews, with columnsid,type,date. Wheretypecan be 'chart', 'dataset', etc.