Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert temporary giving season changes #4385

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

rakyi
Copy link
Contributor

@rakyi rakyi commented Jan 6, 2025

  • Show Subscribe instead of Donate button again
  • Remove call to action top banner

@rakyi rakyi requested a review from mlbrgl January 6, 2025 14:35
@owidbot
Copy link
Contributor

owidbot commented Jan 6, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-revert-giving-season

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2025-01-06 14:53:21 UTC
Execution time: 1.24 seconds

Copy link
Member

@mlbrgl mlbrgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked code and preview, LGTM!

- Show Subscribe instead of Donate button again
- Remove call to action top banner
@rakyi rakyi force-pushed the revert-giving-season branch from 349c35d to 25bacc4 Compare January 7, 2025 09:06
@rakyi rakyi merged commit 3dafb36 into master Jan 7, 2025
11 of 15 checks passed
@rakyi rakyi deleted the revert-giving-season branch January 7, 2025 09:07
sophiamersmann pushed a commit that referenced this pull request Jan 8, 2025
- Show Subscribe instead of Donate button again
- Remove call to action top banner
danyx23 pushed a commit that referenced this pull request Jan 9, 2025
- Show Subscribe instead of Donate button again
- Remove call to action top banner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants