-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 (line) allow to disconnect lines / TAS-775 #4382
Conversation
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2025-01-13 10:07:55 UTC |
d5aafba
to
2e4180b
Compare
e7a9696
to
965c2c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh awesome! I always wanted to have the cherry blossom chart like this, but never made the connection that a line chart is also a scatter already if it just doesn't show the line 😀
965c2c2
to
0aece5e
Compare
0aece5e
to
36139d6
Compare
Resolves #2824
Allow line charts to plot indicators with markers only.
Example on staging: http://staging-site-disconnect-lines/admin/charts/8428/edit
Summary
display
object of an indicator,plotMarkersOnlyInLineChart
I struggled to come up with a good name and in the end went with something explicit,
plotMarkersOnlyInLineChart
. I'm happy to rename if we come up with a better name.I don't know why the default config action is failing, but I don't think it's related to the changes in this PR.
This is part 1 of 3 in a stack made with GitButler: