Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 (line) allow to disconnect lines / TAS-775 #4382

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Jan 6, 2025

Resolves #2824

Allow line charts to plot indicators with markers only.

Example on staging: http://staging-site-disconnect-lines/admin/charts/8428/edit

Summary

  • Adds a new flag to the display object of an indicator, plotMarkersOnlyInLineChart
  • If the flag is enabled for an indicator, then the line chart only draws markers (and doesn't connect data points by a line)
  • Marker-only mode for projections is not supported

I struggled to come up with a good name and in the end went with something explicit, plotMarkersOnlyInLineChart. I'm happy to rename if we come up with a better name.

I don't know why the default config action is failing, but I don't think it's related to the changes in this PR.


This is part 1 of 3 in a stack made with GitButler:

@sophiamersmann sophiamersmann changed the title 🎉 (line) allow to disconnect lines 🎉 (line) allow to disconnect lines / TAS-775 Jan 6, 2025
Copy link

@owidbot
Copy link
Contributor

owidbot commented Jan 6, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-disconnect-lines

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2025-01-13 10:07:55 UTC
Execution time: 1.18 seconds

@sophiamersmann sophiamersmann force-pushed the disconnect-lines branch 5 times, most recently from d5aafba to 2e4180b Compare January 8, 2025 10:49
@sophiamersmann sophiamersmann marked this pull request as ready for review January 9, 2025 10:23
@sophiamersmann sophiamersmann force-pushed the disconnect-lines branch 5 times, most recently from e7a9696 to 965c2c2 Compare January 10, 2025 13:18
@sophiamersmann sophiamersmann added the staging-viz Let SVG tester fail silently in CI label Jan 10, 2025
Copy link
Member

@marcelgerber marcelgerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh awesome! I always wanted to have the cherry blossom chart like this, but never made the connection that a line chart is also a scatter already if it just doesn't show the line 😀

@sophiamersmann sophiamersmann merged commit e56bf5b into master Jan 13, 2025
22 of 23 checks passed
@sophiamersmann sophiamersmann deleted the disconnect-lines branch January 13, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging-viz Let SVG tester fail silently in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LineChart: colouring datapoints by categorical indicators, disconnected datapoints
3 participants