Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (discrete bar) thin zero line #4372

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Jan 2, 2025

Make the zero line of discrete bar charts and stacked discrete bar charts a bit thinner.


This is part 2 of 2 in a stack made with GitButler:

@owidbot
Copy link
Contributor

owidbot commented Jan 2, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-discrete-bar-thin-zero-line

SVG tester:

Number of differences (default views): 488 (92a8b9) ❌
Number of differences (all views): 910 (4f7e9c) ❌

Edited: 2025-01-03 13:25:20 UTC
Execution time: 1.24 seconds

@sophiamersmann sophiamersmann force-pushed the discrete-bar-hide-axis branch from f73c77e to 9fdb051 Compare January 2, 2025 16:00
@sophiamersmann sophiamersmann force-pushed the discrete-bar-thin-zero-line branch from 5393638 to 5e556b1 Compare January 2, 2025 16:00
@sophiamersmann sophiamersmann added the staging-viz Let SVG tester fail silently in CI label Jan 2, 2025
@sophiamersmann sophiamersmann force-pushed the discrete-bar-thin-zero-line branch 2 times, most recently from 04066f8 to ebd7753 Compare January 3, 2025 12:23
Base automatically changed from discrete-bar-hide-axis to master January 3, 2025 12:32
@sophiamersmann sophiamersmann force-pushed the discrete-bar-thin-zero-line branch from 95e1f91 to ebd7753 Compare January 3, 2025 12:39
@sophiamersmann sophiamersmann force-pushed the discrete-bar-thin-zero-line branch 2 times, most recently from 2470dc8 to 2df1f11 Compare January 3, 2025 13:12
@sophiamersmann sophiamersmann marked this pull request as ready for review January 3, 2025 14:14
@sophiamersmann sophiamersmann merged commit daf1174 into master Jan 3, 2025
21 checks passed
@sophiamersmann sophiamersmann deleted the discrete-bar-thin-zero-line branch January 3, 2025 14:15
sophiamersmann added a commit that referenced this pull request Jan 8, 2025
danyx23 pushed a commit that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging-viz Let SVG tester fail silently in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants