✨ (scatter) add unit to axis labels #4334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
sophiamersmann
force-pushed
the
axis-labels-time-viz
branch
from
c2f609e to
2b9e5da
Compare
sophiamersmann
force-pushed
the
scatter-axis-labels-unit
branch
from
1bb8883 to
3863b52
Compare
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 404 (732f3f) ❌ Edited: 2024-12-19 15:56:17 UTC |
sophiamersmann
force-pushed
the
axis-labels-time-viz
branch
from
2b9e5da to
ec4bde7
Compare
sophiamersmann
force-pushed
the
scatter-axis-labels-unit
branch
from
3863b52 to
780f025
Compare
sophiamersmann
force-pushed
the
scatter-axis-labels-unit
branch
from
780f025 to
b9a2e70
Compare
sophiamersmann
force-pushed
the
axis-labels-time-viz
branch
from
ed4d0a3 to
730bbd6
Compare
sophiamersmann
force-pushed
the
scatter-axis-labels-unit
branch
from
b9a2e70 to
49cf3b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should work, but I'd prefer to use the
TextWrapGroup's 'avoid-wrap' functionality to only add line breaks for the unit it necessary. To be able to useTextWrapGroupfor axis labels,TextWrapGroupshould support DoD's (since axis labels might contain DoDs)